Skip to content

Bugfix/issue#1512 #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 28, 2020
Merged

Bugfix/issue#1512 #1518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5c36771
Fix typo in installation developer docs
reobin Jul 25, 2020
9e587fa
Merge pull request #1515 from reobin/patch-1
catarak Jul 27, 2020
d37c552
Merge branch 'master' of https://github.com/processing/p5.js-web-edit…
SundeepChand Jul 27, 2020
e299bf2
fixed search result reset issue
SundeepChand Jul 27, 2020
cb3c824
Fix typo in installation developer docs
reobin Jul 25, 2020
dab1e53
fixed search result reset issue
SundeepChand Jul 27, 2020
9470fd1
[#1512] Update searchbar to query with empty term
catarak Jul 27, 2020
1091a4e
Update searchbar to query with empty term
SundeepChand Jul 28, 2020
cb6d050
removed handleSearchEnter definition which was redundant
SundeepChand Jul 28, 2020
8d379b5
Merge branch 'bugfix/issue#1512' of https://github.com/SundeepChand/p…
SundeepChand Jul 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions client/modules/IDE/components/Searchbar/Searchbar.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,13 @@ class Searchbar extends React.Component {
});
}

handleSearchEnter = (e) => {
if (e.key === 'Enter') {
this.searchChange();
}
}

searchChange = () => {
if (this.state.searchValue.trim().length === 0) return;
this.props.setSearchTerm(this.state.searchValue.trim());
};

handleSearchChange = (e) => {
this.setState({ searchValue: e.target.value }, () => {
this.throttledSearchChange(this.state.searchValue);
this.throttledSearchChange(this.state.searchValue.trim());
});
}

Expand All @@ -53,7 +46,6 @@ class Searchbar extends React.Component {
value={searchValue}
placeholder={this.props.searchLabel}
onChange={this.handleSearchChange}
onKeyUp={this.handleSearchEnter}
/>
<button
className="searchbar__clear-button"
Expand Down
2 changes: 1 addition & 1 deletion developer_docs/installation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ _Note_: The installation steps assume you are using a Unix-like shell. If you ar
* For Mac OSX with [homebrew](http://brew.sh/): `brew tap mongodb/brew` then `brew install mongodb-community` and finally start the server with `brew services start mongodb-community` or you can visit the installation guide here [Installation Guide For MacOS](https://docs.mongodb.com/manual/tutorial/install-mongodb-on-os-x/)
* For Windows and Linux: [MongoDB Installation](https://docs.mongodb.com/manual/installation/)
7. `$ cp .env.example .env`
8. (Optional) Update `.env` with necessary keys to enable certain app behavoirs, i.e. add Github ID and Github Secret if you want to be able to log in with Github.
8. (Optional) Update `.env` with necessary keys to enable certain app behaviors, i.e. add Github ID and Github Secret if you want to be able to log in with Github.
9. `$ npm run fetch-examples` - this downloads the example sketches into a user called 'p5'
10. `$ npm start`
11. Navigate to [http://localhost:8000](http://localhost:8000) in your browser
Expand Down