Skip to content

Conversation

@SundeepChand
Copy link
Contributor

@SundeepChand SundeepChand commented Jul 27, 2020

Fixes #1512

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #1512

@welcome
Copy link

welcome bot commented Jul 27, 2020

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@catarak catarak force-pushed the bugfix/issue#1512 branch from 9ac30d2 to 9470fd1 Compare July 27, 2020 22:14
@catarak
Copy link
Member

catarak commented Jul 27, 2020

Thanks for working on this! In reviewing your code, I ended up wanting to try a different way to approach this. Want to test and confirm it works @SundeepChand?

@SundeepChand
Copy link
Contributor Author

@catarak Yeah, this approach also works. I had also thought of doing the same but was a bit apprehensive about removing some pre-written code.

@SundeepChand
Copy link
Contributor Author

On examining a little further, I found the function handleSearchEnter() to be redundant. So I made this commit.

@catarak
Copy link
Member

catarak commented Jul 28, 2020

@SundeepChand makes sense! Originally when I had worked on this with @raclim we left it in because it didn't seem harmful, but maybe it's good to remove it for the sake of future confusion.

@catarak catarak merged commit a937b76 into processing:develop Jul 28, 2020
@SundeepChand SundeepChand deleted the bugfix/issue#1512 branch July 28, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants