-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Bugfix/issue#1512 #1518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/issue#1512 #1518
Conversation
Fix typo in installation developer docs
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
9ac30d2 to
9470fd1
Compare
|
Thanks for working on this! In reviewing your code, I ended up wanting to try a different way to approach this. Want to test and confirm it works @SundeepChand? |
|
@catarak Yeah, this approach also works. I had also thought of doing the same but was a bit apprehensive about removing some pre-written code. |
|
On examining a little further, I found the function handleSearchEnter() to be redundant. So I made this commit. |
|
@SundeepChand makes sense! Originally when I had worked on this with @raclim we left it in because it didn't seem harmful, but maybe it's good to remove it for the sake of future confusion. |
Fixes #1512
I have verified that this pull request:
npm run lint)Fixes #1512