Skip to content

Conversation

JakubValtar
Copy link
Collaborator

@JakubValtar JakubValtar commented Aug 11, 2025

Fixes cache to have a valid dot graph id.

Before:

graph  polars_query {
  c7e2e5b86-a92c-4b63-8baf-b397a32ad8f2 -- p1
  p1[label="TABLE\nπ */1"]
  c7e2e5b86-a92c-4b63-8baf-b397a32ad8f2[label="CACHE"]
}

After:

graph  polars_query {
  "7e2e5b86-a92c-4b63-8baf-b397a32ad8f2" -- p1
  p1[label="TABLE\nπ */1"]
  "7e2e5b86-a92c-4b63-8baf-b397a32ad8f2"[label="CACHE"]
}

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Aug 11, 2025
@ritchie46
Copy link
Member

What was the problem?

Copy link

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.59%. Comparing base (a67bf04) to head (dac5567).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-plan/src/plans/ir/dot.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24005      +/-   ##
==========================================
+ Coverage   81.57%   81.59%   +0.01%     
==========================================
  Files        1675     1675              
  Lines      225601   225708     +107     
  Branches     2897     2897              
==========================================
+ Hits       184040   184167     +127     
+ Misses      40834    40813      -21     
- Partials      727      728       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coastalwhite coastalwhite merged commit 47cd618 into pola-rs:main Aug 11, 2025
25 checks passed
@JakubValtar
Copy link
Collaborator Author

JakubValtar commented Aug 11, 2025

In the UUID PR, the cache ID changed from a number (hex string) to UUID with dashes in it, and dashes are not allowed in dot node IDs without the ID being surrounded by quotes.

@JakubValtar JakubValtar deleted the fix-cache-dot branch August 11, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants