-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
refactor: Use UUID for UniqueID #23704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
crates/polars-utils/src/unique_id.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: The main changes are in this file.
@@ -229,7 +229,7 @@ pub struct Cache { | |||
#[pyo3(get)] | |||
input: usize, | |||
#[pyo3(get)] | |||
id_: usize, | |||
id_: u128, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: The Python IR interface change is here.
The lowerhex isn't important. Normal print should be fine. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23704 +/- ##
==========================================
+ Coverage 81.25% 81.29% +0.03%
==========================================
Files 1644 1644
Lines 223318 223250 -68
Branches 2841 2841
==========================================
+ Hits 181452 181481 +29
+ Misses 41167 41070 -97
Partials 699 699 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR switches
UniqueID
to use UUID internally. This ensures uniqueness and preserves the ability to generate new unique IDs even after deserialization.@wence- This changes the Python IR interface. The
Cache::id_
field changes fromusize
tou128
since the ids now use 128 bits. I bumped theVERSION
.Closes #23674