Revert "Add SPI-based withMainSerialExecutor (#81)"
#83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6158334.
stephencelis
added
the
apple bug
stephencelis
added a commit
to pointfreeco/swift-composable-architecture
that referenced
this pull request
Apr 14, 2023
See pointfreeco/swift-dependencies#83 for more info.
stephencelis
added a commit
to pointfreeco/swift-composable-architecture
that referenced
this pull request
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately an Xcode bug prevents us from shipping a library with a C module without breaking common downstream scenarios, like an app having a unit test target. Trying to build such a target results in a compile error:
While it is possible to work around the bug by publicly exposing the
_CAsyncSupportmodule as a product and instructing users to manually link to this module in their test targets when they encounter this error, this is a bit of a support nightmare to manage for a helper that's hidden by SPI.For more information, see:
swift-atomicsissue, which mentions that this is a tooling issue that cannot be solved by the package alone. Here's hoping Xcode 15 has a fix soon!GRDB.swiftissue, which had the same problem and provides documentation to the end user to manually solve the problem.This reverts commit 6158334.