Add SPI-based withMainSerialExecutor
#81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helper makes it easier to [reliably test Swift concurrency](https://forums.swift.org/t/reliably-testing-code-that-adopts-swift-concurrency/57304/81).
stephencelis
changed the title
_withMainSerialExecutorwithMainSerialExecutor
mbrandonw
approved these changes
Apr 13, 2023
stephencelis
added a commit
that referenced
this pull request
Apr 14, 2023
This reverts commit 6158334.
stephencelis
added a commit
that referenced
this pull request
Apr 14, 2023
This reverts commit 6158334.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helper makes it easier to reliably test Swift concurrency.
It was originally siloed to the Composable Architecture's test target, but it'd be good to use it beyond that case. Rather than ship it in TCA, we can ship it upstream in the same library that already introduces concurrency helpers for testing.
In the future we may break it out further:
swift-main-serial-executor: Could be in its own nano-library as a single exported function.swift-concurrency-helpers(or-supportor-test-supportor something else): Could be included in a library where we extract out all of this library's concurrency helpers.