Skip to content

Conversation

@optionsome
Copy link
Member

@optionsome optionsome commented Feb 28, 2025

Summary

This pr is opened mainly to demonstrate what changes a prettier java update would cause. If we want to do the update, this pr should be approved and then the formatting commit will be redone before merge.

Issue

No issue

Unit tests

Only formatting updates

Documentation

No updates

Changelog

Skipped

@optionsome optionsome added !Technical Debt Improve code quality, no functional changes. +Skip Changelog This is not a relevant change for a product owner since last release. labels Feb 28, 2025
@codecov
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 65.33505% with 807 lines in your changes missing coverage. Please review.

Project coverage is 70.19%. Comparing base (2c8cfdb) to head (bf513fe).
Report is 6 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...ntripplanner/apis/gtfs/generated/GraphQLTypes.java 48.37% 103 Missing and 8 partials ⚠️
...anner/apis/transmodel/TransmodelGraphQLSchema.java 53.25% 79 Missing ⚠️
...pplanner/apis/gtfs/datafetchers/QueryTypeImpl.java 32.29% 61 Missing and 4 partials ⚠️
...entripplanner/apis/gtfs/datafetchers/StopImpl.java 0.00% 50 Missing ⚠️
...anner/ext/siri/updater/azure/SiriAzureUpdater.java 13.33% 26 Missing ⚠️
...er/ext/debugrastertiles/ElevationEdgeRenderer.java 0.00% 16 Missing ⚠️
...anner/ext/vehicleparking/bikely/BikelyUpdater.java 0.00% 16 Missing ⚠️
...is/transmodel/model/siri/et/EstimatedCallType.java 63.63% 16 Missing ⚠️
...pentripplanner/apis/gtfs/DefaultValueInjector.java 39.13% 14 Missing ⚠️
...mapping/routerequest/LegacyRouteRequestMapper.java 67.44% 14 Missing ⚠️
... and 114 more
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6500      +/-   ##
=============================================
+ Coverage      70.14%   70.19%   +0.05%     
+ Complexity     18311    18310       -1     
=============================================
  Files           2080     2080              
  Lines          77799    77182     -617     
  Branches        7833     7831       -2     
=============================================
- Hits           54573    54181     -392     
+ Misses         20455    20231     -224     
+ Partials        2771     2770       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@optionsome optionsome marked this pull request as ready for review March 3, 2025 08:22
@optionsome optionsome requested a review from a team as a code owner March 3, 2025 08:22
@leonardehrenfried
Copy link
Member

I'm in favour for this but have you coordinated with the rest of the team?

@optionsome
Copy link
Member Author

We quickly discussed this with @t2gran. He thought we should review the changes and if they are approved, the formatting commit should be redone and then merged in without waiting for approvals. However, we probably should wait for #6477 to be merged in first (or any other big pr if there are others).

Copy link
Member

@leonardehrenfried leonardehrenfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is never going to be a good time without big PRs in the pipeline so now is as good as any other time.

t2gran
t2gran previously approved these changes Mar 4, 2025
Copy link
Member

@t2gran t2gran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realy do not like that it now break lines on ( and ) and not .. I prefer that stuff with the same scope is indented at the same level. Now method calls are broken into more lines, while method chains is not. This was one of the main reasons for choosing prettier.

@optionsome optionsome dismissed stale reviews from t2gran and leonardehrenfried via bf513fe March 4, 2025 13:03
@optionsome optionsome merged commit 04fadbf into opentripplanner:dev-2.x Mar 4, 2025
6 checks passed
@optionsome optionsome deleted the update-prettier branch March 4, 2025 13:11
@t2gran t2gran added this to the 2.7 milestone Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+Skip Changelog This is not a relevant change for a product owner since last release. !Technical Debt Improve code quality, no functional changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants