-
Couldn't load subscription status.
- Fork 1.1k
Update prettier java version #6500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bcc817b to
eee4555
Compare
|
I'm in favour for this but have you coordinated with the rest of the team? |
|
We quickly discussed this with @t2gran. He thought we should review the changes and if they are approved, the formatting commit should be redone and then merged in without waiting for approvals. However, we probably should wait for #6477 to be merged in first (or any other big pr if there are others). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is never going to be a good time without big PRs in the pipeline so now is as good as any other time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realy do not like that it now break lines on ( and ) and not .. I prefer that stuff with the same scope is indented at the same level. Now method calls are broken into more lines, while method chains is not. This was one of the main reasons for choosing prettier.
bf513fe
eee4555 to
bf513fe
Compare
Summary
This pr is opened mainly to demonstrate what changes a prettier java update would cause. If we want to do the update, this pr should be approved and then the formatting commit will be redone before merge.
Issue
No issue
Unit tests
Only formatting updates
Documentation
No updates
Changelog
Skipped