-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Support for coordinates in via search #6477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an be use everywhere
The old multi-criteria pass-through parameters does not work any more.
0ad1f7a to
7a97e8f
Compare
The via mapping was done in the mc-criteria mapping block, but the via is part of the search-criteria
optionsome
reviewed
Feb 26, 2025
...n/src/main/java/org/opentripplanner/apis/transmodel/model/framework/CoordinateInputType.java
Outdated
Show resolved
Hide resolved
...org/opentripplanner/routing/algorithm/raptoradapter/transit/mappers/RaptorRequestMapper.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/opentripplanner/routing/via/model/ViaCoordinateTransfer.java
Outdated
Show resolved
Hide resolved
optionsome
reviewed
Feb 27, 2025
application/src/main/java/org/opentripplanner/street/model/vertex/TemporaryStreetLocation.java
Outdated
Show resolved
Hide resolved
raptor/src/main/java/org/opentripplanner/raptor/path/PathBuilderLeg.java
Outdated
Show resolved
Hide resolved
.../opentripplanner/raptor/rangeraptor/multicriteria/ViaConnectionStopArrivalEventListener.java
Show resolved
Hide resolved
raptor/src/test/java/org/opentripplanner/raptor/moduletests/J03_ViaTransferSearchTest.java
Outdated
Show resolved
Hide resolved
raptor/src/test/java/org/opentripplanner/raptor/moduletests/J03_ViaTransferSearchTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Joel Lappalainen <[email protected]>
The feature this code adressed is solved elsewhere.
optionsome
previously approved these changes
Feb 27, 2025
81092fa to
7fb79a7
Compare
optionsome
approved these changes
Feb 28, 2025
eibakke
reviewed
Mar 3, 2025
application/src/main/java/org/opentripplanner/routing/graphfinder/NearbyStop.java
Show resolved
Hide resolved
eibakke
approved these changes
Mar 3, 2025
t2gran
pushed a commit
that referenced
this pull request
Mar 3, 2025
|
I have just read this PR and want to add the functionality to my client for OTP 2.7.0, but the GTFS GraphQL API still says that "Coordinates are NOT supported yet." for the visit via points. Can anyone explain to me what this PR has achieved? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Explain in one or two sentences what this PR achieves.
Issue
This is part of #4887 and fixes the top bullet point: #4887 (comment)
Unit tests
✅ I have added unit-test on some of the existing features witch did not have sufficent test covarage
✅ I also added module tests on the via coordinate raptor implementation
✅ I have fixed part of the broken Itinerary mapping tests
Documentation
✅ JavaDoc
✅ Transmodel API doc on via-coordinate
Changelog
✅ Should be included
Bumping the serialization version id
Not needed. There is no changes to the state of domain classes.
StreetEdgeis changed, but this should work ok with serialization. The enumLinkingDirectionis changed, but this should not be serialized.