-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Re-add block-based interlining #4264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add block-based interlining #4264
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4264 +/- ##
=============================================
+ Coverage 56.89% 56.96% +0.07%
- Complexity 10586 10603 +17
=============================================
Files 1402 1404 +2
Lines 57170 57213 +43
Branches 6603 6604 +1
=============================================
+ Hits 32526 32591 +65
+ Misses 22630 22621 -9
+ Partials 2014 2001 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b775f61 to
fe0aa17
Compare
src/main/java/org/opentripplanner/graph_builder/module/interlining/InterlineProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/gtfs/mapping/TransferMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/gtfs/mapping/TransferMapper.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Hannes Junnila <[email protected]>
9c34bc1 to
6414dbb
Compare
|
Sorry @hannesj, I accidentally rebase after your review. :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it seemed to work.
src/main/java/org/opentripplanner/graph_builder/module/interlining/InterlineProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/graph_builder/module/interlining/InterlineProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/graph_builder/module/interlining/InterlineProcessor.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Hannes Junnila <[email protected]>
Summary
Re-implements the block-based interlining from OTP1.
It does so by splitting
GeometryAndBlockProcessorinto smaller pieces, one for the geometries and one for the interlining.Issue
n/a
Unit tests
Unit and integration tests added.
I removed the tests from
GeometryAndBlockProcessorTestthat were supposed to be, according to #4105.Documentation
n/a