forked from opentripplanner/OpenTripPlanner
-
Notifications
You must be signed in to change notification settings - Fork 2
Upstream merge 2022-07-14 #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As milliseconds are never used.
…-rides Remove Ride class from DefaultFareService implementations
Report better issues from shape geometry errors
Use full seconds for A-star state
…lification Read in NeTEx geometries directly
Co-authored-by: Hannes Junnila <[email protected]>
…mpotent_upload_to_gcs Configure idempotent upload to Google Cloud Storage
Co-authored-by: Hannes Junnila <[email protected]>
Co-authored-by: Hannes Junnila <[email protected]>
Re-add block-based interlining
…api-layer Add mapping layer between REST API and internal fare model
…alculation Add Houston fare calculator
miles-grant-ibigroup
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great thanks for getting this through so quickly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following features relevant for IBI:
Note that the config for the fare calculator has changed ever so slightly. You now need to express the
freeTransferWindowin ISO8601-ish duration syntax, so it's2h30minstead of150.Full example is here: https://github.com/opentripplanner/OpenTripPlanner/blob/dev-2.x/src/ext-test/java/org/opentripplanner/ext/fares/FaresConfigurationTest.java#L23-L27