This repository was archived by the owner on Jun 7, 2021. It is now read-only.
feat: use tekton Pipeline and add JSFunctionBuild #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #13 Extract all of the build code into a separate file, and adjust the logic in the controller so that the ConfigMap is updated and a new TaskRun is created when the function source changes.
This also means that the kn service will be updated with the new image tag when a function changes and is rebuilt, allowing for auto deployment of modified functions.
This change adds a new CRD - `JSFunctionBuild` whose responsibility is to run a Tekton `Pipeline` when it is provided with a new revision of the `JSFunction` container image URL. The controller manages a Tekton `PipelineResource` for each function. When the function changes and a new image/tag is needed, the controller updates the `PipelineResource` with the new image tag, and then initiates a build.
lance
requested review from
jcrossley3,
rhuss,
slinkydeveloper and
zroubalik
zroubalik
reviewed
Sep 4, 2019
Contributor
zroubalik
left a comment
zroubalik
left a comment
There was a problem hiding this comment.
LGTM, there are just a very minor comments from my side.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new CRD -
JSFunctionBuildwhose responsibility is torun a Tekton
Pipelinewhen it is provided with a new revision of theJSFunctioncontainer image URL. The controller manages a TektonPipelineResourcefor each function. When the function changes and a newimage/tag is needed, the controller updates the
PipelineResourcewith thenew image tag, and then initiates a build.
This pull request supercedes #16
Fixes #13