Skip to content

Conversation

@jsikstro
Copy link
Member

@jsikstro jsikstro commented Nov 5, 2025

Hello,

This RFE deprecates the AlwaysActAsServerClassMachine and NeverActAsServrClassMachine flags in JDK 26. Please see the CSR for specific details on why these flag are being deprecated.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8370844 to be approved

Issues

  • JDK-8370843: Deprecate AlwaysActAsServerClassMachine and NeverActAsServerClassMachine (Enhancement - P4)
  • JDK-8370844: Deprecate AlwaysActAsServerClassMachine and NeverActAsServerClassMachine (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28148/head:pull/28148
$ git checkout pull/28148

Update a local copy of the PR:
$ git checkout pull/28148
$ git pull https://git.openjdk.org/jdk.git pull/28148/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28148

View PR using the GUI difftool:
$ git pr show -t 28148

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28148.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 5, 2025

👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@jsikstro This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370843: Deprecate AlwaysActAsServerClassMachine and NeverActAsServerClassMachine

Reviewed-by: ayang, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@jsikstro The following labels will be automatically applied to this pull request:

  • graal
  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 5, 2025
@jsikstro jsikstro changed the title 8370843: Deprecate AlwaysActAsServerClassMachine and NeverActAsServrClassMachine 8370843: Deprecate AlwaysActAsServerClassMachine and NeverActAsServerClassMachine Nov 5, 2025
@jsikstro
Copy link
Member Author

jsikstro commented Nov 5, 2025

/label remove graal

@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@jsikstro
The graal label was successfully removed.

@mlbridge
Copy link

mlbridge bot commented Nov 5, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 5, 2025
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@vnkozlov
Copy link
Contributor

vnkozlov commented Nov 5, 2025

@jsikstro do we have any test which use these flags?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants