Skip to content

Conversation

Waheiba
Copy link
Contributor

@Waheiba Waheiba commented Aug 19, 2025

This addresses a similar issue as #877
Headers values are added twice which concatenates the same value again over the existing for the same header.

createRequest(body:endpoint:) in OtlpHttpExporterBase already considers envVarHeaders and config.headers
Additional looping on those headers in OtlpHttpTraceExporter after the request is created is appending the same value again.

Tests are also added

Apologies for the other PR that I closed. Small accident with commit history.

@bryce-b
Copy link
Member

bryce-b commented Aug 20, 2025

Apologies for the other PR that I closed. Small accident with commit history.

I hate it when that happens :)

Thanks for the contribution @Waheiba
Could you extend this change to the other exporters as well?
Nevermind, I thought this issue was with all the exporters

@Waheiba
Copy link
Contributor Author

Waheiba commented Aug 20, 2025

Thanks for the contribution @Waheiba

My pleasure :)

I couldn't find in the docs how to request or start a release. If you could point this out would be great. Creating a pre-release version would be awesome after merging this PR.

@bryce-b bryce-b enabled auto-merge (squash) August 21, 2025 18:52
@bryce-b bryce-b merged commit 4f33acb into open-telemetry:main Aug 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants