Skip to content

fix: OtlpHttpTraceExporter request headers. #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 4, 2025
Merged

fix: OtlpHttpTraceExporter request headers. #877

merged 2 commits into from
Aug 4, 2025

Conversation

Waheiba
Copy link
Contributor

@Waheiba Waheiba commented Jul 27, 2025

createRequest(body:endpoint:) in OtlpHttpExporterBase already considers envVarHeaders and config.headers
Additional looping on those headers in OtlpHttpTraceExporter after the request is created is appending the same value again.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jul 27, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@Waheiba Waheiba changed the title Fix OtlpHttpTraceExporter request headers. fix: OtlpHttpTraceExporter request headers. Jul 27, 2025
@Waheiba Waheiba force-pushed the fix-OtlpHttpTraceExporter-request-headers branch from 0202636 to c6ee70e Compare July 31, 2025 11:47
@Waheiba
Update OtlpHttpTraceExporterTests.swift
9e2754c 
Fix OtlpHttpTraceExporter request headers when envVarHeaders or config are provided

Adding Test coverage on export()
@Waheiba Waheiba force-pushed the fix-OtlpHttpTraceExporter-request-headers branch from c6ee70e to 9e2754c Compare July 31, 2025 11:48
@Waheiba
Copy link
Contributor Author

Waheiba commented Jul 31, 2025

I updated the test for linux.
the header casing was actually different when running in a linux environment to from testHeader to Testheader.
I'm changing the filter to be all lowercased.
Looks less pretty tho but gets away with any case sensitive issues for the headers

@bryce-b bryce-b enabled auto-merge (squash) August 4, 2025 21:23
@bryce-b bryce-b merged commit 4b1b2e9 into open-telemetry:main Aug 4, 2025
9 of 10 checks passed
This was referenced Aug 18, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvydier vvydier vvydier approved these changes

@nachoBonafonte nachoBonafonte nachoBonafonte approved these changes

@bryce-b bryce-b bryce-b approved these changes

@ArielDemarco ArielDemarco Awaiting requested review from ArielDemarco ArielDemarco is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Waheiba @vvydier @nachoBonafonte @bryce-b