Skip to content

win: upgrade Visual Studio workload from 2019 to 2022 #60318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2025
Merged

win: upgrade Visual Studio workload from 2019 to 2022 #60318

merged 1 commit into from
Oct 25, 2025
+1 −1

Conversation

@gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Oct 19, 2025 •
edited by richardlau
Loading

Fixes: #59031

@nodejs-github-bot nodejs-github-bot added install Issues and PRs related to the installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Oct 19, 2025
@gengjiawen gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2025
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Oct 19, 2025
@github-actions
Copy link
Contributor

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/18626818218

@MikeMcC399 MikeMcC399 mentioned this pull request Oct 23, 2025
Closed
@MikeMcC399

This comment was marked as resolved.

Sign in to view
@richardlau richardlau linked an issue Oct 23, 2025 that may be closed by this pull request
Outdated visualstudio2019-workload-vctools in Node.js 22+ Windows install_tools.bat #59031
Closed
@richardlau richardlau added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Oct 23, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69860/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69872/

@richardlau richardlau added commit-queue Add this label to land a pull request using GitHub Actions. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Oct 25, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 25, 2025
@nodejs-github-bot nodejs-github-bot merged commit 7bc76d9 into nodejs:main Oct 25, 2025
87 of 92 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 7bc76d9

aduh95 pushed a commit that referenced this pull request Oct 26, 2025
@gengjiawen @aduh95
win: upgrade Visual Studio workload from 2019 to 2022
e5559f3 
PR-URL: #60318
Fixes: #59031
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@github-actions github-actions bot mentioned this pull request Oct 27, 2025
Merged
@Daverd-GM
Copy link

I realize this issue is closed, but should this patch also be applied to the 24 LTS branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. install Issues and PRs related to the installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Outdated visualstudio2019-workload-vctools in Node.js 22+ Windows install_tools.bat