test: fix status when compiled without inspector

PR-URL: #60289
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>

Author: aduh95

test/common/index.js

@@ -54,6 +54,7 @@ const noop = () => {};
 const hasCrypto = Boolean(process.versions.openssl) &&
                   !process.env.NODE_SKIP_CRYPTO;
 
+const hasInspector = Boolean(process.features.inspector);
 const hasSQLite = Boolean(process.versions.sqlite);
 
 const hasQuic = hasCrypto && !!process.features.quic;
@@ -711,7 +712,7 @@ function expectsError(validator, exact) {
 }
 
 function skipIfInspectorDisabled() {
-  if (!process.features.inspector) {
+  if (!hasInspector) {
     skip('V8 inspector is disabled');
   }
 }
@@ -930,6 +931,7 @@ const common = {
   hasIntl,
   hasCrypto,
   hasQuic,
+  hasInspector,
   hasSQLite,
   invalidArgTypeHelper,
   isAlive,

test/common/index.mjs

@@ -17,6 +17,7 @@ const {
   getTTYfd,
   hasCrypto,
   hasQuic,
+  hasInspector,
   hasSQLite,
   hasIntl,
   hasIPv6,
@@ -68,6 +69,7 @@ export {
   getTTYfd,
   hasCrypto,
   hasQuic,
+  hasInspector,
   hasSQLite,
   hasIntl,
   hasIPv6,

test/common/wpt.js

@@ -412,6 +412,9 @@ class BuildRequirement {
     // Not using common.hasCrypto because of the global leak checks
     this.hasCrypto = Boolean(process.versions.openssl) &&
       !process.env.NODE_SKIP_CRYPTO;
+
+    // Not using common.hasInspector because of the global leak checks
+    this.hasInspector = Boolean(process.features.inspector);
   }
 
   /**
@@ -429,6 +432,9 @@ class BuildRequirement {
     if (requires.has('crypto') && !this.hasCrypto) {
       return 'crypto';
     }
+    if (requires.has('inspector') && !this.hasInspector) {
+      return 'inspector';
+    }
     return false;
   }
 }

test/parallel/test-process-get-builtin.mjs

@@ -1,4 +1,4 @@
-import { hasCrypto, hasIntl, hasSQLite } from '../common/index.mjs';
+import { hasCrypto, hasIntl, hasInspector, hasSQLite } from '../common/index.mjs';
 import assert from 'node:assert';
 import { builtinModules } from 'node:module';
 import { isMainThread } from 'node:worker_threads';
@@ -39,6 +39,10 @@ if (!hasIntl) {
 // TODO(@jasnell): Remove this once node:quic graduates from unflagged.
 publicBuiltins.delete('node:quic');
 
+if (!hasInspector) {
+  publicBuiltins.delete('inspector');
+  publicBuiltins.delete('inspector/promises');
+}
 if (!hasSQLite) {
   publicBuiltins.delete('node:sqlite');
 }

test/wpt/status/console.json

@@ -1,7 +1,7 @@
 {
   "idlharness.any.js": {
     "note": "https://github.com/nodejs/node/issues/44185",
-    "requires": ["crypto", "small-icu"]
+    "requires": ["crypto", "inspector", "small-icu"]
   },
   "idlharness-shadowrealm.window.js": {
     "skip": "ShadowRealm support is not enabled"