GLSLNodeBuilder: Fix texture()
code generation for depth texture
#31770
+6
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the discussion in #31760, this PR fixes an issue where
texture()
in WebGLBackend generating incorrect UV code, resulting a GLSL compilation error.The argument to GLSL's
texture()
can bevec4
, when the sampler issampler2DArrayShadow
for example, but theuvSnippet
ingenerateTexture
should not be assumed to bevec3
, and it should be handled separately.https://github.com/mrdoob/three.js/blob/r179/src/renderers/webgl-fallback/nodes/GLSLNodeBuilder.js#L403