-
-
Notifications
You must be signed in to change notification settings - Fork 36k
GLSLNodeBuilder: Fix texelFetch*()
code generation with depth textures.
#31760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+20
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
shotamatsuda
commented
Aug 27, 2025
Mugen87
reviewed
Aug 27, 2025
shotamatsuda
commented
Aug 27, 2025
Mugen87
previously approved these changes
Aug 27, 2025
texelFetch*()
code generation with depth textures.
3 tasks
Mugen87
approved these changes
Aug 27, 2025
@shotamatsuda Could you please open a new PR with your changes to fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #31759.
Description
This PR fixes
TextureNode.load()
incorrectly returnsvec4
when sampling a depth texture on WebGL fallback.