Skip to content

chore(cli-repl): track executable size as performance metric #2569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2025
Merged

chore(cli-repl): track executable size as performance metric #2569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion packages/cli-repl/src/smoke-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ export async function runSmokeTests({
});
}
const perfResults: PerfTestResult[] = [];
const commonPerfTags = [process.arch, process.platform];

for (const {
name,
Expand Down Expand Up @@ -365,7 +366,7 @@ export async function runSmokeTests({
perfResults.push({
info: {
test_name: name,
tags: [...(tags ?? []), process.arch, process.platform],
tags: [...(tags ?? []), ...commonPerfTags],
},
created_at,
completed_at,
Expand All @@ -378,6 +379,22 @@ export async function runSmokeTests({
}
}
if (wantPerformanceTesting) {
perfResults.push({
info: {
test_name: 'executable_size',
tags: [...commonPerfTags],
},
created_at: new Date().toISOString(),
completed_at: new Date().toISOString(),
Copy link
Contributor

@gagik gagik Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want a different completition value?

Copy link
Collaborator Author

@addaleax addaleax Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would mainly be relevant for tasks that actually measure durations

artifacts: [],
metrics: [
{
name: 'size_bytes_mean',
type: 'MEAN',
Comment on lines +392 to +393
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using 'MEAN' as the metric type for a single measurement of executable size is misleading, as there's no averaging occurring. Consider using a more appropriate type like 'VALUE' or 'GAUGE' to accurately represent that this is a single point-in-time measurement.

Suggested change
name: 'size_bytes_mean',
type: 'MEAN',
name: 'size_bytes',
type: 'VALUE',

Copilot uses AI. Check for mistakes.
Copy link
Collaborator Author

@addaleax addaleax Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about whether this is a supported value even, given that the docs are gone away due to https://github.com/10gen/performance-tooling-docs/blob/main/getting_started/migrating_from_perfSend_to_sps.md

value: (await fs.stat(process.execPath)).size,
},
],
});
console.log(JSON.stringify(perfResults));
} else {
console.log('all tests passed');
Expand Down
Loading