chore(cli-repl): track executable size as performance metric #2569
Conversation
addaleax
added
the
no-title-validation
There was a problem hiding this comment.
Pull Request Overview
This PR adds tracking of the Node.js executable size as a performance metric in the CLI REPL smoke tests. The change introduces a new performance test result that captures the size of the executable binary being used to run the tests.
Key Changes:
- Extracts common performance tags (architecture and platform) into a reusable constant
- Adds a new performance metric for tracking executable binary size
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name: 'size_bytes_mean', | ||
| type: 'MEAN', |
There was a problem hiding this comment.
Using 'MEAN' as the metric type for a single measurement of executable size is misleading, as there's no averaging occurring. Consider using a more appropriate type like 'VALUE' or 'GAUGE' to accurately represent that this is a single point-in-time measurement.
| name: 'size_bytes_mean', | |
| type: 'MEAN', | |
| name: 'size_bytes', | |
| type: 'VALUE', |
There was a problem hiding this comment.
Not sure about whether this is a supported value even, given that the docs are gone away due to https://github.com/10gen/performance-tooling-docs/blob/main/getting_started/migrating_from_perfSend_to_sps.md
| tags: [...commonPerfTags], | ||
| }, | ||
| created_at: new Date().toISOString(), | ||
| completed_at: new Date().toISOString(), |
There was a problem hiding this comment.
do we want a different completition value?
There was a problem hiding this comment.
I think this would mainly be relevant for tasks that actually measure durations
No description provided.