Fix URL safe string decoding for DownloadPublicObject API #3328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesnietor
requested review from
allanrogerr,
bayasdev,
bexsoft,
dvaldivia,
jinapurapu and
kaankabalak
jinapurapu
approved these changes
May 3, 2024
bexsoft
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3327
Similar to #3305 it uses url safe base64 decoding for the download of the object. Used in Share File functionality. The previous PR fixed the creation of the URL (encoding), this fixes the decoding of it.
Includes unittest.
Test steps:
With an existing bucket, folder and objects.
with .jpg, .svg, .png, spaces, etc