Skip to content

Conversation

cesnietor
Copy link
Collaborator

@cesnietor cesnietor commented Apr 22, 2024

fixes: #3304

Uses URLEncoding instead of StdEncoding to ensure url-safe strings.
Includes test.

Test steps:

With an existing bucket, folder and objects.

  • With different filenames e,.g. with .jpg, .svg, .png, spaces, etc
  • Click share file
  • Copy and paste the new url in the browser
  • The url should contain same url as Object browser
  • Object should be downloaded
  • Test injecting wrong urls (base64encoded)
  • Should return error or forbidden errors if url doesn't point to internal MinIO server

@cesnietor cesnietor marked this pull request as ready for review April 22, 2024 19:00
@cesnietor cesnietor self-assigned this Apr 22, 2024
Copy link
Contributor

@bayasdev bayasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@allanrogerr
Copy link
Contributor

LGTM - tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path encoded in share link url is not url-safe
3 participants