chore: capture all branch protection policy #2430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for creating a Pull Request @MIchaelMainer. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
|
Tracking issue with https://github.com/microsoft/GitOps.Branches/issues/74 |
gavinbarron
reviewed
Jun 12, 2023
gavinbarron
reviewed
Jun 13, 2023
Mnickii
approved these changes
Jun 13, 2023
|
4 invalid rules
Total execution time: 0.19 seconds |
sebastienlevert
pushed a commit
that referenced
this pull request
Jun 23, 2023
* fix: remove react peer dependency (#2389) * fix: add top to the caching key to allow varying values with different page sizes (#2406) Signed-off-by: Martin Musale <[email protected]> * chore: capture all branch protection policy (#2430) * chore: capture all branch protection policy * wrap pattern in quotes * fix: set requiresStrictStatusChecks to false requiresStrictStatusChecks should be false if we don't have one or more status checks defined in requiredStatusChecks property. --------- Signed-off-by: Martin Musale <[email protected]> Co-authored-by: Musale Martin <[email protected]> Co-authored-by: Michael Mainer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Description of the changes
Capture current policy state so that we can make versioned changes to branch protection policies. This will enable policy history, auditing, review, standardization, and templatization. We will update policy in later PR.
We can ignore the rule that states:
At least one value under RequiredStatusChecks must be specified when RequiresStrictStatusChecks is true.This is getting removedPR checklist
yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense)Other information
Need to add this before we remove this repo from the org policy so that capture all of our existing branch policy.