fix: add top to the file-list cache key signature #2406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e sizes Signed-off-by: Martin Musale <[email protected]>
|
Thank you for creating a Pull Request @musale. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
|
The updated storybook is available here |
1 similar comment
|
The updated storybook is available here |
gavinbarron
approved these changes
Jun 6, 2023
sebastienlevert
pushed a commit
that referenced
this pull request
Jun 23, 2023
* fix: remove react peer dependency (#2389) * fix: add top to the caching key to allow varying values with different page sizes (#2406) Signed-off-by: Martin Musale <[email protected]> * chore: capture all branch protection policy (#2430) * chore: capture all branch protection policy * wrap pattern in quotes * fix: set requiresStrictStatusChecks to false requiresStrictStatusChecks should be false if we don't have one or more status checks defined in requiredStatusChecks property. --------- Signed-off-by: Martin Musale <[email protected]> Co-authored-by: Musale Martin <[email protected]> Co-authored-by: Michael Mainer <[email protected]>
This was referenced Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2147
PR Type
Description of the changes
Added top to the file-list caching key signature. This allows for variable and unique keys to use to cache when you vary the page-size attribute for the file-list.
PR checklist
yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense)Other information
Keys will look like this in indexDb: Example for getting files from my drive: