TabView: Separate border lines into being everywhere except the selected tab #6332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RBrid
reviewed
Nov 18, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RBrid
requested changes
Nov 19, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RBrid
approved these changes
Nov 19, 2021
…ded padding inside the ItemsPresenter.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
added
area-TabView
team-Controls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The single border line that ran underneath the selected tab doesn't work when the selected tab color is partly transparent. This change breaks it up to run underneath all of the pieces of TabView separately -- which is a lot of places -- except for the selected tab. When the user is dragging a tab, however, we hide all those individual pieces and show a single line again.