Skip to content

Conversation

@ericstj
Copy link
Member

@ericstj ericstj commented Apr 29, 2025

Also fixes a couple of potential NullRefs in the dotnet detector.

@ericstj ericstj requested a review from grvillic April 29, 2025 00:47
@ericstj ericstj requested a review from a team as a code owner April 29, 2025 00:47
@codecov
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.6%. Comparing base (bf16661) to head (84c06b2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ection.Detectors/dotnet/DotNetComponentDetector.cs 0.0% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1388     +/-   ##
=======================================
- Coverage   89.6%   89.6%   -0.1%     
=======================================
  Files        402     401      -1     
  Lines      31825   31820      -5     
  Branches    1964    1964             
=======================================
- Hits       28545   28540      -5     
  Misses      2863    2863             
  Partials     417     417             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grvillic grvillic enabled auto-merge (squash) April 29, 2025 21:19
@grvillic grvillic merged commit 81e93c7 into microsoft:main Apr 29, 2025
18 of 22 checks passed
@github-actions
Copy link

github-actions bot commented Apr 29, 2025

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@JamieMagee
Copy link
Member

FYI this breaks all integration tests:

Error Message:
   Initialization method Microsoft.ComponentDetection.VerificationTests.ComponentDetectionIntegrationTests.GatherResources threw exception. System.Collections.Generic.KeyNotFoundException: The given key 'DotNet' was not present in the dictionary..
  Stack Trace:
      at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at Microsoft.ComponentDetection.Contracts.BcdeModels.TypedComponentConverter.ReadJson(JsonReader reader, Type objectType, Object existingValue, JsonSerializer serializer) in /home/runner/work/component-detection/component-detection/src/Microsoft.ComponentDetection.Contracts/BcdeModels/TypedComponentConverter.cs:line 48

@grvillic
Copy link
Collaborator

Good catch! It autocompleted since the checks are not required to be merged for some reason. I will update tests shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants