Promote DotNet detector out of experiment (#1388)

* Fix a coup[e potential NullRefs in dotnet detector

* Promote DotNet detector

---------

Co-authored-by: Greg Villicana <[email protected]>

Author: ericstj

src/Microsoft.ComponentDetection.Detectors/dotnet/DotNetComponentDetector.cs

@@ -17,7 +17,7 @@ namespace Microsoft.ComponentDetection.Detectors.DotNet;
 using Microsoft.ComponentDetection.Contracts.TypedComponent;
 using Microsoft.Extensions.Logging;
 
-public class DotNetComponentDetector : FileComponentDetector, IExperimentalDetector
+public class DotNetComponentDetector : FileComponentDetector
 {
     private const string GlobalJsonFileName = "global.json";
     private readonly ICommandLineInvocationService commandLineInvocationService;
@@ -138,9 +138,12 @@ protected override async Task OnFileFoundAsync(ProcessRequest processRequest, ID
     {
         var lockFile = this.lockFileFormat.Read(processRequest.ComponentStream.Stream, processRequest.ComponentStream.Location);
 
-        if (lockFile.PackageSpec is null)
+        if (lockFile.PackageSpec is null || lockFile.PackageSpec.RestoreMetadata is null)
         {
-            this.Logger.LogWarning("Lock file {LockFilePath} does not contain a PackageSpec.", processRequest.ComponentStream.Location);
+            // The lock file is not valid, or does not contain a PackageSpec.
+            // This could be due to the lock file being generated by a different version of the SDK.
+            // We should not fail the detector, but we should log a warning.
+            this.Logger.LogWarning("Lock file {LockFilePath} does not contain project information.", processRequest.ComponentStream.Location);
             return;
         }
 
@@ -181,7 +184,7 @@ protected override async Task OnFileFoundAsync(ProcessRequest processRequest, ID
         var targetType = this.GetProjectType(projectOutputPath, projectName, cancellationToken);
 
         var componentReporter = this.ComponentRecorder.CreateSingleFileComponentRecorder(projectPath);
-        foreach (var target in lockFile.Targets)
+        foreach (var target in lockFile.Targets ?? [])
         {
             var targetFramework = target.TargetFramework?.GetShortFolderName();
 

src/Microsoft.ComponentDetection.Orchestrator/Experiments/DotNetDetectorExperiment.cs

@@ -66,7 +66,6 @@ public static IServiceCollection AddComponentDetection(this IServiceCollection s
         services.AddSingleton<IExperimentConfiguration, SimplePipExperiment>();
         services.AddSingleton<IExperimentConfiguration, RustCliDetectorExperiment>();
         services.AddSingleton<IExperimentConfiguration, Go117DetectorExperiment>();
-        services.AddSingleton<IExperimentConfiguration, DotNetDetectorExperiment>();
 
         // Detectors
         // CocoaPods