Skip to content

Conversation

@MathiasVP
Copy link
Collaborator

@MathiasVP MathiasVP commented Feb 21, 2025

I want to handle implicit importing somewhat differently than what I did in #132. So for now I'll revert it.

  • The first commit is a revert of PS: #132 follow-up #133 - except that I'm keeping extraction of .psd1 files
  • The second commit is a revert of PS: Extract source files found via PSModulePath #132 - except that I'm keeping the upgrade and downgrade scripts
  • The third commit is fixes a small bug in the upgrade script generator. Previously, it was relying on being run only from the github/codeql repo. I've fixed up the script so that it works on the Microsoft repo.
  • The final commit modifies the upgrade and downgrade script to be compatible with the revert in the second commit.

Thanks for all the feedback so far, @dilanbhalla!

@MathiasVP MathiasVP marked this pull request as draft February 24, 2025 13:37
@MathiasVP MathiasVP force-pushed the revert-ps-module-extraction branch from a464cc7 to 2bd239b Compare February 24, 2025 13:37
@MathiasVP MathiasVP force-pushed the revert-ps-module-extraction branch from 2bd239b to 29c11a4 Compare February 24, 2025 14:24
@MathiasVP MathiasVP marked this pull request as ready for review February 24, 2025 14:27
@MathiasVP MathiasVP merged commit 4e6f463 into main Feb 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants