PS: #132 follow-up #133
Merged
PS: #132 follow-up #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h files and use that new option when running ql tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #132 which I merged earlier this morning. In that PR, we started extracting Powershell files found via the
PSModulePathenvironment variable, and added a CLI parameter to selectively disable this feature.However, I forgot to add an official "extractor option" to control this. Without this extractor option it's not possible to disable
PSModulePathextraction when runningcodeql test run. We need to disablePSModulePathextraction when runningcodeql test runto ensure that the tests are independent of the environment in which the tests are run.