Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Start by installing the **nightly** build of PyTorch following the
Then, the easiest way to install the rest of the dependencies is to run:

```bash
conda install cmake pkg-config pybind11 "ffmpeg<8" -c conda-forge
conda install cmake pkg-config pybind11 "ffmpeg<9" -c conda-forge
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and below, let's remove the bound, FFmpeg 9 isn't out and probably won't be anytime soon, and using ffmpeg<9 may suggest to some users that we don't support the latest FFmpeg - which we do!

The intent behind ffmpeg<8 was that for a short period of time, FFmpeg 8 was released and we didn't support it, so users would potentially get a conflict. But there's no risk of conflict ATM since FFmpeg 9 doesn't exist.

Suggested change
conda install cmake pkg-config pybind11 "ffmpeg<9" -c conda-forge
conda install cmake pkg-config pybind11 "ffmpeg" -c conda-forge

```

### Clone and build
Expand Down
15 changes: 7 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,16 +107,16 @@ ffmpeg -f lavfi -i \
`torch` and `torchcodec`.

2. Install FFmpeg, if it's not already installed. Linux distributions usually
come with FFmpeg pre-installed. TorchCodec supports major FFmpeg versions
in [4, 7] on all platforms, and FFmpeg version 8 is supported on Mac and Linux.
come with FFmpeg pre-installed. TorchCodec supports supports all major FFmpeg versions
in [4, 8].

If FFmpeg is not already installed, or you need a more recent version, an
easy way to install it is to use `conda`:

```bash
conda install "ffmpeg<8"
conda install "ffmpeg<9"
# or
conda install "ffmpeg<8" -c conda-forge
conda install "ffmpeg<9" -c conda-forge
```

3. Install TorchCodec:
Expand Down Expand Up @@ -148,16 +148,15 @@ format you want. Refer to Nvidia's GPU support matrix for more details
[here](https://developer.nvidia.com/video-encode-and-decode-gpu-support-matrix-new).

1. Install FFmpeg with NVDEC support.
TorchCodec with CUDA should work with FFmpeg versions in [4, 7] on all platforms,
and FFmpeg version 8 is supported on Linux.
TorchCodec with CUDA should work with FFmpeg versions in [4, 8].

If FFmpeg is not already installed, or you need a more recent version, an
easy way to install it is to use `conda`:

```bash
conda install "ffmpeg<8"
conda install "ffmpeg<9"
# or
conda install "ffmpeg<8" -c conda-forge
conda install "ffmpeg<9" -c conda-forge
```

After installing FFmpeg make sure it has NVDEC support when you list the supported
Expand Down
2 changes: 1 addition & 1 deletion src/torchcodec/_core/ops.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def load_torchcodec_shared_libraries():
raise RuntimeError(
f"""Could not load libtorchcodec. Likely causes:
1. FFmpeg is not properly installed in your environment. We support
versions 4, 5, 6, and 7 on all platforms, and 8 on Mac and Linux.
versions 4, 5, 6, 7, and 8.
2. The PyTorch version ({torch.__version__}) is not compatible with
this version of TorchCodec. Refer to the version compatibility
table:
Expand Down
Loading