Update docs to indicate support for FFmpeg 8 on all platforms #1004
+9
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
NicolasHug
reviewed
Oct 28, 2025
CONTRIBUTING.md
Outdated
|
|
||
| ```bash | ||
| conda install cmake pkg-config pybind11 "ffmpeg<8" -c conda-forge | ||
| conda install cmake pkg-config pybind11 "ffmpeg<9" -c conda-forge |
There was a problem hiding this comment.
Here and below, let's remove the bound, FFmpeg 9 isn't out and probably won't be anytime soon, and using ffmpeg<9 may suggest to some users that we don't support the latest FFmpeg - which we do!
The intent behind ffmpeg<8 was that for a short period of time, FFmpeg 8 was released and we didn't support it, so users would potentially get a conflict. But there's no risk of conflict ATM since FFmpeg 9 doesn't exist.
Suggested change
| conda install cmake pkg-config pybind11 "ffmpeg<9" -c conda-forge | |
| conda install cmake pkg-config pybind11 "ffmpeg" -c conda-forge |
NicolasHug
approved these changes
Oct 28, 2025
There was a problem hiding this comment.
Thanks @Dan-Flores , LGTM with the comment above to remove the bound
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, the installation commands now find
FFmpeg<9as suggested in #861.