Skip to content

fix: replace @ts-ignore with proper TypeScript typing in useScript #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: replace @ts-ignore with proper TypeScript typing in useScript #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/hooks/useScript.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,10 @@ export default function useScript({
scriptEl.src = src;

Object.keys(attributes).forEach((key) => {
// @ts-ignore
if (scriptEl[key] === undefined) {
if (!(key in scriptEl)) {
scriptEl.setAttribute(key, attributes[key]);
} else {
// @ts-ignore
scriptEl[key] = attributes[key];
(scriptEl as any)[key] = attributes[key];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using an explicit type assertion is better than @ts-ignore, but consider using a more specific type like (scriptEl as Record<string, any>)[key] instead of any to maintain some type safety while still allowing dynamic property access.

}
});

Expand Down