fix: replace @ts-ignore with proper TypeScript typing in useScript #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: replace @ts-ignore with proper TypeScript typing in useScript
Summary
Replaced problematic
@ts-ignorecomments in the useScript hook with proper TypeScript typing. The changes improve type safety while maintaining the same functionality for setting attributes on HTMLScriptElement objects.Key changes:
@ts-ignorewith explicit(scriptEl as any)type assertionscriptEl[key] === undefinedto!(key in scriptEl)Review & Testing Checklist for Human
setAttribute()and direct property assignment paths work correctly with real script attributes (e.g.,async,defer,crossorigin)!(key in scriptEl)behaves identically toscriptEl[key] === undefinedfor HTMLScriptElement properties - this is the main behavioral changeNotes
as anycast is more transparent than@ts-ignorebut still bypasses type safety for this specific lineLink to Devin run: https://app.devin.ai/sessions/b3abc6bba0d74c31a560e682d6617bfc
Requested by: @hmafzal