-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: Update contributing.md to include local tests #2744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
please consider correcting the small typo on line 43 before review. Should be |
Thanks for this suggestion. fixed |
CONTRIBUTING.md
Outdated
|
||
We recommend you to do local testing on your changes before pushing. | ||
|
||
You need first to validate your modules: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need first to validate your modules: | |
You need to first validate your modules: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. fixed 👍🏻
/lgtm cc @CatherineF-dev to verify |
/hold |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: onasser1, richabanker The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cab4fa1
to
a5588df
Compare
New changes are detected. LGTM label has been removed. |
/assign |
What this PR does / why we need it:
Encourage new contributors to do local tests before pushing changes
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
N/A
Which issue(s) this PR fixes: (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged)Fixes #2743