Skip to content

Promote GEP 3171 - Percentage Based Request mirroring to standard #3633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Promote GEP 3171 - Percentage Based Request mirroring to standard #3633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8533389
Move GEP 3171 to experimental
LiorLieberman Feb 25, 2025
955ec5b
apply feedback
LiorLieberman Feb 25, 2025
db41ff3
fix
LiorLieberman Feb 26, 2025
da22408
fix
LiorLieberman Feb 26, 2025
e7a4666
codegen
LiorLieberman Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apis/openapi/zz_generated.openapi.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apis/v1/grpcroute_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,7 @@ type GRPCRouteFilter struct {
//
// +optional
//
// <gateway:experimental:validation:XValidation:message="Only one of percent or fraction may be specified in HTTPRequestMirrorFilter",rule="!(has(self.percent) && has(self.fraction))">
// +kubebuilder:validation:XValidation:message="Only one of percent or fraction may be specified in HTTPRequestMirrorFilter",rule="!(has(self.percent) && has(self.fraction))"
RequestMirror *HTTPRequestMirrorFilter `json:"requestMirror,omitempty"`

// ExtensionRef is an optional, implementation-specific extension to the
Expand Down
4 changes: 1 addition & 3 deletions apis/v1/httproute_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,7 +855,7 @@ type HTTPRouteFilter struct {
//
// +optional
//
// <gateway:experimental:validation:XValidation:message="Only one of percent or fraction may be specified in HTTPRequestMirrorFilter",rule="!(has(self.percent) && has(self.fraction))">
// +kubebuilder:validation:XValidation:message="Only one of percent or fraction may be specified in HTTPRequestMirrorFilter",rule="!(has(self.percent) && has(self.fraction))"
RequestMirror *HTTPRequestMirrorFilter `json:"requestMirror,omitempty"`

// RequestRedirect defines a schema for a filter that responds to the
Expand Down Expand Up @@ -1263,7 +1263,6 @@ type HTTPRequestMirrorFilter struct {
// +optional
// +kubebuilder:validation:Minimum=0
// +kubebuilder:validation:Maximum=100
// <gateway:experimental>
Percent *int32 `json:"percent,omitempty"`

// Fraction represents the fraction of requests that should be
Expand All @@ -1273,7 +1272,6 @@ type HTTPRequestMirrorFilter struct {
// is specified, 100% of requests will be mirrored.
//
// +optional
// <gateway:experimental>
Fraction *Fraction `json:"fraction,omitempty"`
}

Expand Down
80 changes: 80 additions & 0 deletions config/crd/standard/gateway.networking.k8s.io_grpcroutes.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading