Skip to content

Promote GEP 3171 - Percentage Based Request mirroring to standard #3633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Promote GEP 3171 - Percentage Based Request mirroring to standard #3633

wants to merge 5 commits into from

Conversation

LiorLieberman
Copy link
Member

/kind cleanup
/kind documentation

What this PR does / why we need it:
Promote Percentage Based Request mirroring to standard

Does this PR introduce a user-facing change?:

promote percentage-based-request-mirroring to standard

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 25, 2025
@k8s-ci-robot k8s-ci-robot added kind/gep PRs related to Gateway Enhancement Proposal(GEP) size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 25, 2025
@LiorLieberman
Copy link
Member Author

Should I also remove experimental from here? (and from grpcroute)?

gateway-api/apis/v1/httproute_types.go

Lines 858 to 859 in cbde2d2

// <gateway:experimental:validation:XValidation:message="Only one of percent or fraction may be specified in HTTPRequestMirrorFilter",rule="!(has(self.percent) && has(self.fraction))">
RequestMirror *HTTPRequestMirrorFilter `json:"requestMirror,omitempty"`

@LiorLieberman
Copy link
Member Author

/cc @kflynn

@k8s-ci-robot k8s-ci-robot requested a review from kflynn February 25, 2025 17:40
@kflynn
Copy link
Contributor

kflynn commented Feb 25, 2025

Should I also remove experimental from here? (and from grpcroute)?

Yes, I believe so. Looks good so far, thanks for getting this in!

@LiorLieberman LiorLieberman changed the title Move GEP 3171 - Promote Percentage Based Request mirroring to standard Promote GEP 3171 - Percentage Based Request mirroring to standard Feb 25, 2025
@blake
Copy link
Contributor

blake commented Feb 25, 2025

This line also needs to be moved to the standard section of the navigation sidebar.

gateway-api/mkdocs.yml

Line 143 in cbde2d2

- geps/gep-3171/index.md

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 25, 2025
kflynn
kflynn approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LiorLieberman! 🙂

@kflynn
Copy link
Contributor

kflynn commented Feb 25, 2025

/retest

robscott
robscott approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LiorLieberman! Ping me once you run codegen and I'll LGTM.

geps/gep-3171/index.md
@@ -1,7 +1,7 @@
# GEP-3171: Percentage-based Request Mirroring

* Issue: [#3171](https://github.com/kubernetes-sigs/gateway-api/issues/3171)
* Status: **Experimental**
* Status: Standard
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend keeping formatting

Suggested change
* Status: Standard
* Status: **Standard**

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? all of other index.md files are without **

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More importantly, the metadata.yaml file in this directory must also be updated. (That's actually the canonical location).

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kflynn, LiorLieberman, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2025
@youngnick
Copy link
Contributor

Aside from making the metadata.yaml changes and (probably) rerunning make generate, this LGTM.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 26, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 26, 2025
@k8s-ci-robot
Copy link
Contributor

@LiorLieberman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gateway-api-verify e7a4666 link true /test pull-gateway-api-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

robscott
robscott reviewed Feb 27, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LiorLieberman! This also LGTM once metadata.yaml and codegen are updated.

@LiorLieberman
Copy link
Member Author

opened #3638 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott approved these changes

@youngnick youngnick youngnick left review comments

@gcs278 gcs278 Awaiting requested review from gcs278

+1 more reviewer

@kflynn kflynn kflynn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. kind/gep PRs related to Gateway Enhancement Proposal(GEP) needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LiorLieberman @kflynn @blake @k8s-ci-robot @youngnick @robscott