Skip to content

⚠️SecurityGroupFilter to SecurityGroupParam #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2024
Merged

⚠️SecurityGroupFilter to SecurityGroupParam #1974

merged 1 commit into from
Mar 29, 2024

Conversation

@mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Mar 27, 2024 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 27, 2024
@netlify
Copy link

netlify bot commented Mar 27, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 865933d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6606c1106f97ea0008e70b6a
😎 Deploy Preview https://deploy-preview-1974--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdbooth mdbooth force-pushed the securitygroupparam branch 2 times, most recently from 4b7211a to e0f407f Compare March 27, 2024 19:58
@mdbooth mdbooth mentioned this pull request Mar 27, 2024
Merged
5 tasks
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 27, 2024

/test pull-cluster-api-provider-openstack-e2e-full-test

@mdbooth mdbooth force-pushed the securitygroupparam branch from e0f407f to 4442f0d Compare March 28, 2024 12:45
@mdbooth mdbooth mentioned this pull request Mar 28, 2024
Merged
4 tasks
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 28, 2024

/test pull-cluster-api-provider-openstack-e2e-full-test

@mdbooth mdbooth mentioned this pull request Mar 28, 2024
Merged
5 tasks
@mdbooth mdbooth force-pushed the securitygroupparam branch from 4442f0d to edbb720 Compare March 28, 2024 17:23
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 28, 2024
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 28, 2024

/test pull-cluster-api-provider-openstack-e2e-full-test

@mdbooth mdbooth force-pushed the securitygroupparam branch from edbb720 to bbeabad Compare March 28, 2024 21:09
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 28, 2024
@mdbooth mdbooth force-pushed the securitygroupparam branch from bbeabad to de283e6 Compare March 28, 2024 22:06
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 28, 2024

/test pull-cluster-api-provider-openstack-e2e-full-test

dulek
dulek suggested changes Mar 29, 2024
View reviewed changes
api/v1alpha6/types_conversion.go Outdated
}

func Convert_v1alpha6_SecurityGroupFilter_To_v1beta1_SecurityGroupFilter(in *SecurityGroupFilter, out *infrav1.SecurityGroupFilter, s apiconversion.Scope) error {
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks weird?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eurgh. Forgot to remove this :(

api/v1beta1/types.go
Comment on lines +105 to 113
// SecurityGroupFilter specifies a query to select an OpenStack security group. At least one property must be set.
// +kubebuilder:validation:MinProperties:=1
type SecurityGroupFilter struct {
ID string `json:"id,omitempty"`
Name string `json:"name,omitempty"`
Description string `json:"description,omitempty"`
ProjectID string `json:"projectID,omitempty"`

FilterByNeutronTags `json:",inline"`
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably take the opportunity to add descriptions here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but I'm trying to minimise this series as much as possible. These can probably all do with pointerification, too, but both can happen post v1beta1 release so I'd prefer to punt.

@mdbooth mdbooth force-pushed the securitygroupparam branch from de283e6 to 865933d Compare March 29, 2024 13:24
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 29, 2024
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 29, 2024

Last push simply removes the commented code.

@dulek
Copy link
Contributor

dulek commented Mar 29, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2024
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 29, 2024

/hold cancel

I'd re-run the full test, but as I literally only removed some commented-out-code since it last ran successfully on this PR I won't.
(- Words on my tombstone)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 52652d3 into kubernetes-sigs:main Mar 29, 2024
@mdbooth mdbooth deleted the securitygroupparam branch March 29, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmilienM EmilienM Awaiting requested review from EmilienM

@jichenjc jichenjc Awaiting requested review from jichenjc

1 more reviewer

@dulek dulek dulek requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dulek dulek

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

CAPO Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdbooth @k8s-ci-robot @dulek