Skip to content

⚠️ Split ImageFilter into ImageParam #1970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 29, 2024
Merged

⚠️ Split ImageFilter into ImageParam #1970

merged 3 commits into from
Mar 29, 2024

Conversation

@mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Mar 25, 2024 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2024
@k8s-ci-robot k8s-ci-robot requested review from EmilienM and dulek March 25, 2024 15:15
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 25, 2024
@netlify
Copy link

netlify bot commented Mar 25, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 44be48e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6606c14776200c000841e2b7
😎 Deploy Preview https://deploy-preview-1970--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdbooth mdbooth force-pushed the imageparam branch 2 times, most recently from a1f0ffd to b0c02d2 Compare March 26, 2024 11:48
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 26, 2024

/test pull-cluster-api-provider-openstack-test

@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 26, 2024

I don't immediately understand this failure. AFAICT the generated files are up to date.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 27, 2024
@mdbooth mdbooth force-pushed the imageparam branch 2 times, most recently from a19352c to 98fa8d4 Compare March 27, 2024 17:43
@mdbooth mdbooth mentioned this pull request Mar 27, 2024
Merged
3 tasks
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 27, 2024

It's failing to load an OpenStackMachineTemplate which contains an invalid imageparam. However, looking at the generated templated artifacts I can't see it. I don't currently know where the invalid data is coming from.

@mdbooth mdbooth force-pushed the imageparam branch 2 times, most recently from bb6d07c to b1a5e7b Compare March 28, 2024 12:59
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 28, 2024

It's failing to load an OpenStackMachineTemplate which contains an invalid imageparam. However, looking at the generated templated artifacts I can't see it. I don't currently know where the invalid data is coming from.

Found it: I'd missed where the flatcar templates patch the image separately.

@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 28, 2024

/test pull-cluster-api-provider-openstack-e2e-full-test

@mdbooth mdbooth mentioned this pull request Mar 28, 2024
Merged
5 tasks
@mdbooth mdbooth force-pushed the imageparam branch 2 times, most recently from 9fe500c to 8ee7baa Compare March 28, 2024 17:24
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 28, 2024
@mdbooth mdbooth mentioned this pull request Mar 28, 2024
Merged
5 tasks
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 28, 2024

/test pull-cluster-api-provider-openstack-test
/test pull-cluster-api-provider-openstack-e2e-full-test

@mdbooth mdbooth force-pushed the imageparam branch 2 times, most recently from 39c94a9 to 9ad02ed Compare March 28, 2024 22:06
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 28, 2024

/test pull-cluster-api-provider-openstack-e2e-full-test

@dulek
Copy link
Contributor

dulek commented Mar 29, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2024
@dulek
Copy link
Contributor

dulek commented Mar 29, 2024

@mdbooth: Does this need a rebase or can I just unhold this?

@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 29, 2024

As long as the previous one merged, just unhold it.

@dulek
Copy link
Contributor

dulek commented Mar 29, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit e32bcc2 into kubernetes-sigs:main Mar 29, 2024
@mdbooth mdbooth deleted the imageparam branch March 29, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dulek dulek Awaiting requested review from dulek

@EmilienM EmilienM Awaiting requested review from EmilienM

Assignees

@dulek dulek

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

CAPO Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdbooth @k8s-ci-robot @dulek