Skip to content

Conversation

RasmusKjeldgaard
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard commented Feb 28, 2022

Which issue does this PR close?

This PR closes #2026

What is the new behavior?

Across the code, any reference to master branch has been renamed to stable to better reflect our release workflow.

Right before merging this, we should rename the master branch to stable here on github.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be automatically merged to master via automerge.

@RasmusKjeldgaard RasmusKjeldgaard changed the title Housekeeping/2026 rename master to stable Rename master branch to stable Feb 28, 2022
@RasmusKjeldgaard RasmusKjeldgaard changed the base branch from main to master February 28, 2022 12:27
@github-actions github-actions bot temporarily deployed to pr-2026-rename-master-to-stable February 28, 2022 12:32 Inactive
@github-actions github-actions bot temporarily deployed to pr-2026-rename-master-to-stable February 28, 2022 12:40 Inactive
jkaltoft
jkaltoft previously approved these changes Mar 4, 2022
Copy link
Collaborator

@jkaltoft jkaltoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I would expect the Github workflows to run exactly as before.

I've added a suggestion, but I think it's optional.

@MadsBuchmann
Copy link
Contributor

Should anything be done in local repositories when this change is merged 👀 ?

@RasmusKjeldgaard
Copy link
Collaborator Author

Should anything be done in local repositories when this change is merged 👀 ?

Yes! I'll do a quick writeup of the details later, in a discussion post!

@RasmusKjeldgaard RasmusKjeldgaard merged commit 141c07f into stable Mar 7, 2022
@RasmusKjeldgaard RasmusKjeldgaard deleted the housekeeping/2026-rename-master-to-stable branch March 7, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Housekeeping] Rename master branch to stable
3 participants