You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* π Rename master to stable in Github actions
* π Rename master to stable in markdown files
* π Rename master to stable in cookbook links
* π Rename master to stable in misc build scripts
* π Rename master to stable in segm. control doc
* π Revert unintentional changes to ToCs
* π Wrap stable in backticks in documentation
Copy file name to clipboardExpand all lines: .github/CONTRIBUTING.md
+6-6Lines changed: 6 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -81,7 +81,7 @@ This consists of code-reviewing your own pull request, following guidelines foun
81
81
82
82
> Confirmation from UXers that the implementation complies with what was decided during UX Refinement.
83
83
84
-
If the implementation of the issue resulted in visual changes - then it has to be UX reviewed. This is to make sure that the introduced changes align with the design system. We strive to have every issue that introduces visual changes UX reviewed. If this is not done and the changes are merged to master, we might recieve issues about components not being properly aligned with the design system anymore from the users of Kirby.
84
+
If the implementation of the issue resulted in visual changes - then it has to be UX reviewed. This is to make sure that the introduced changes align with the design system. We strive to have every issue that introduces visual changes UX reviewed. If this is not done and the changes are merged to `stable`, we might recieve issues about components not being properly aligned with the design system anymore from the users of Kirby.
85
85
86
86
## Before you get coding
87
87
@@ -103,7 +103,7 @@ If you got an idea for a component that you think should be part of Kirby you sh
103
103
3.**Implementation:**
104
104
- Make sure you have read: "[Before you get coding](#before-you-get-coding)".
105
105
- Signal to others you are working on the issue by assigning yourself.
106
-
- Create a branch from the [master branch](https://github.com/kirbydesign/designsystem/tree/master) following our [branch naming convention](https://github.com/kirbydesign/designsystem/wiki/The-Good%3A-Branch).
106
+
- Create a branch from the [stable branch](https://github.com/kirbydesign/designsystem/tree/stable) following our [branch naming convention](https://github.com/kirbydesign/designsystem/wiki/The-Good%3A-Branch).
107
107
- Publish a WIP implementation to Github as a draft PR and ask for feedback.
108
108
- Make sure you have implemented tests following the guidelines in: "[The good: Test](https://github.com/kirbydesign/designsystem/wiki/The-Good%3A-Test)".
109
109
- Update the [cookbook](https://cookbook.kirby.design) with examples and showcases.
@@ -112,7 +112,7 @@ If you got an idea for a component that you think should be part of Kirby you sh
112
112
- Create a pull request. If you created a draft PR during implementation you can just mark that as "ready for review".
113
113
- Request that the pull request is code-reviewed.
114
114
- Request that the pull request is [UX reviewed](#ux-review).
115
-
- When the pull request has been approved it will be automatically merged to master via [automerge](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/automatically-merging-a-pull-request).
115
+
- When the pull request has been approved it will be automatically merged to `stable` via [automerge](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/automatically-merging-a-pull-request).
116
116
5.**Celebrate! π**
117
117
118
118
## Checklist: I have an enhancement
@@ -133,7 +133,7 @@ If you have found a bug in Kirby you should follow these steps:
133
133
3.**Implementation:**
134
134
- Make sure you have read: "[Before you get coding](#before-you-get-coding)".
135
135
- Signal to others you are working on the issue by assigning yourself.
136
-
- Create a branch from the [master branch](https://github.com/kirbydesign/designsystem/tree/master) following our [branch naming convention](https://github.com/kirbydesign/designsystem/wiki/The-Good%3A-Branch).
136
+
- Create a branch from the [stable branch](https://github.com/kirbydesign/designsystem/tree/stable) following our [branch naming convention](https://github.com/kirbydesign/designsystem/wiki/The-Good%3A-Branch).
137
137
- Create a test that reproduces the bug following guidelines in: "[The good: Test](https://github.com/kirbydesign/designsystem/wiki/The-Good%3A-Test)".
138
138
- Write code to fix the bug
139
139
4.**Follow steps 4 and 5 in "[Checklist: I have a component request](#checklist-i-have-a-component-request)".**
@@ -172,7 +172,7 @@ You should now be able to open `http://localhost:4200` in a browser to access th
172
172
173
173
[Node](https://nodejs.org/en/) is the runtime used for development.
174
174
175
-
The supported version of NodeJS can be found in the file [`package.json`](https://github.com/kirbydesign/designsystem/blob/master/package.json) under `engines`. At the time of writing it for example looks like this:
175
+
The supported version of NodeJS can be found in the file [`package.json`](https://github.com/kirbydesign/designsystem/blob/stable/package.json) under `engines`. At the time of writing it for example looks like this:
176
176
177
177
```Javascript
178
178
...
@@ -224,7 +224,7 @@ As with TSLint, we strongly recommend installing Prettier as a plugin for your
224
224
It can however be used without an editor plugin; run `npm run prettier` to check for formatting errors, fix them by running `npm run prettier:fix` .
225
225
226
226
If there are changes only concerning formatting, in files you did not create - do not commit these. There is most likely something wrong with your Prettier settings.
227
-
Make sure that Prettier uses the config file that is shipped with the repository ([`.prettierrc.json`](https://github.com/kirbydesign/designsystem/blob/master/.prettierrc.json)) and not a global configuration located on your machine.
227
+
Make sure that Prettier uses the config file that is shipped with the repository ([`.prettierrc.json`](https://github.com/kirbydesign/designsystem/blob/stable/.prettierrc.json)) and not a global configuration located on your machine.
228
228
229
229
To check if the config file from the repository is used, try to alter the configuration in `.prettierrc.json` and format a file using Prettier - for example by changing `"singleQuote": true,` to `"singleQuote": false, ` .
230
230
If all quotation marks are changed to `"` instead of `'` when you format, it means the repository config file is used by Prettier. Remember to revert the changes made to `.prettierrc.json` .
Copy file name to clipboardExpand all lines: .github/ISSUE_TEMPLATE/bug_report.md
+4-4Lines changed: 4 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -47,19 +47,19 @@ The good issue: contains only one issue, is self-contained, is specific & unambi
47
47
48
48
## Checklist:
49
49
50
-
The following tasks should be carried out in sequence in order to follow [the process of contributing](https://github.com/kirbydesign/designsystem/blob/master/.github/CONTRIBUTING.md/#the-process-of-contributing) correctly.
50
+
The following tasks should be carried out in sequence in order to follow [the process of contributing](https://github.com/kirbydesign/designsystem/blob/stable/.github/CONTRIBUTING.md/#the-process-of-contributing) correctly.
51
51
52
52
### Verification
53
53
To make sure the bug is not intended behaviour; it should be verified by a member of team Kirby before moving on to implementation.
54
54
55
-
-[ ] Make sure the `NOT verified` label has been removed by a member of [team Kirby](https://github.com/kirbydesign/designsystem/blob/master/.github/SUPPORT.md#team-kirby); do not proceed until this is done
55
+
-[ ] Make sure the `NOT verified` label has been removed by a member of [team Kirby](https://github.com/kirbydesign/designsystem/blob/stable/.github/SUPPORT.md#team-kirby); do not proceed until this is done
56
56
57
57
### Implementation
58
58
The contributor who wants to implement this issue should:
59
59
60
-
-[ ] Make sure you have read: "[Before you get coding](https://github.com/kirbydesign/designsystem/blob/master/.github/CONTRIBUTING.md/#before-you-get-coding)".
60
+
-[ ] Make sure you have read: "[Before you get coding](https://github.com/kirbydesign/designsystem/blob/stable/.github/CONTRIBUTING.md/#before-you-get-coding)".
61
61
-[ ] Signal to others you are working on the issue by assigning yourself.
62
-
-[ ] Create a branch from the [master branch](https://github.com/kirbydesign/designsystem/tree/master) following our [branch naming convention](https://github.com/kirbydesign/designsystem/wiki/The-Good%3A-Branch).
62
+
-[ ] Create a branch from the [stable branch](https://github.com/kirbydesign/designsystem/tree/stable) following our [branch naming convention](https://github.com/kirbydesign/designsystem/wiki/The-Good%3A-Branch).
63
63
-[ ] Create a test that reproduces the bug following guidelines in: "[The good: Test](https://github.com/kirbydesign/designsystem/wiki/The-Good%3A-Test)".
Copy file name to clipboardExpand all lines: .github/ISSUE_TEMPLATE/component-request.md
+5-5Lines changed: 5 additions & 5 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -28,19 +28,19 @@ The good issue: contains only one issue, is self-contained, is specific & unambi
28
28
29
29
## Checklist:
30
30
31
-
The following tasks should be carried out in sequence in order to follow [the process of contributing](https://github.com/kirbydesign/designsystem/blob/master/.github/CONTRIBUTING.md/#the-process-of-contributing) correctly.
31
+
The following tasks should be carried out in sequence in order to follow [the process of contributing](https://github.com/kirbydesign/designsystem/blob/stable/.github/CONTRIBUTING.md/#the-process-of-contributing) correctly.
32
32
33
33
### Refinement
34
34
35
-
-[ ] Request that the issue is [UX refined](https://github.com/kirbydesign/designsystem/blob/master/.github/CONTRIBUTING.md/#ux-refinement); do not proceed until this is done.
36
-
-[ ] Request that the issue is [tech refined](https://github.com/kirbydesign/designsystem/blob/master/.github/CONTRIBUTING.md/#tech-refinement); do not proceed until this is done.
35
+
-[ ] Request that the issue is [UX refined](https://github.com/kirbydesign/designsystem/blob/stable/.github/CONTRIBUTING.md/#ux-refinement); do not proceed until this is done.
36
+
-[ ] Request that the issue is [tech refined](https://github.com/kirbydesign/designsystem/blob/stable/.github/CONTRIBUTING.md/#tech-refinement); do not proceed until this is done.
37
37
38
38
### Implementation
39
39
The contributor who wants to implement this issue should:
40
40
41
-
-[ ] Make sure you have read: "[Before you get coding](https://github.com/kirbydesign/designsystem/blob/master/.github/CONTRIBUTING.md/#before-you-get-coding)".
41
+
-[ ] Make sure you have read: "[Before you get coding](https://github.com/kirbydesign/designsystem/blob/stable/.github/CONTRIBUTING.md/#before-you-get-coding)".
42
42
-[ ] Signal to others you are working on the issue by assigning yourself.
43
-
-[ ] Create a branch from the [master branch](https://github.com/kirbydesign/designsystem/tree/master) following our [branch naming convention](https://github.com/kirbydesign/designsystem/wiki/The-Good%3A-Branch).
43
+
-[ ] Create a branch from the [stable branch](https://github.com/kirbydesign/designsystem/tree/stable) following our [branch naming convention](https://github.com/kirbydesign/designsystem/wiki/The-Good%3A-Branch).
44
44
-[ ] Publish a WIP implementation to Github as a draft PR and ask for feedback.
45
45
-[ ] Make sure you have implemented tests following the guidelines in: "[The good: Test](https://github.com/kirbydesign/designsystem/wiki/The-Good%3A-Test)".
46
46
-[ ] Update the [cookbook](https://cookbook.kirby.design) with examples and showcases.
Copy file name to clipboardExpand all lines: .github/ISSUE_TEMPLATE/enhancement-request.md
+5-5Lines changed: 5 additions & 5 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -31,19 +31,19 @@ The good issue: contains only one issue, is self-contained, is specific & unambi
31
31
32
32
## Checklist:
33
33
34
-
The following tasks should be carried out in sequence in order to follow [the process of contributing](https://github.com/kirbydesign/designsystem/blob/master/.github/CONTRIBUTING.md/#the-process-of-contributing) correctly.
34
+
The following tasks should be carried out in sequence in order to follow [the process of contributing](https://github.com/kirbydesign/designsystem/blob/stable/.github/CONTRIBUTING.md/#the-process-of-contributing) correctly.
35
35
36
36
### Refinement
37
37
38
-
-[ ] Request that the issue is [UX refined](https://github.com/kirbydesign/designsystem/blob/master/.github/CONTRIBUTING.md/#ux-refinement); do not proceed until this is done.
39
-
-[ ] Request that the issue is [tech refined](https://github.com/kirbydesign/designsystem/blob/master/.github/CONTRIBUTING.md/#tech-refinement); do not proceed until this is done.
38
+
-[ ] Request that the issue is [UX refined](https://github.com/kirbydesign/designsystem/blob/stable/.github/CONTRIBUTING.md/#ux-refinement); do not proceed until this is done.
39
+
-[ ] Request that the issue is [tech refined](https://github.com/kirbydesign/designsystem/blob/stable/.github/CONTRIBUTING.md/#tech-refinement); do not proceed until this is done.
40
40
41
41
### Implementation
42
42
The contributor who wants to implement this issue should:
43
43
44
-
-[ ] Make sure you have read: "[Before you get coding](https://github.com/kirbydesign/designsystem/blob/master/.github/CONTRIBUTING.md/#before-you-get-coding)".
44
+
-[ ] Make sure you have read: "[Before you get coding](https://github.com/kirbydesign/designsystem/blob/stable/.github/CONTRIBUTING.md/#before-you-get-coding)".
45
45
-[ ] Signal to others you are working on the issue by assigning yourself.
46
-
-[ ] Create a branch from the [master branch](https://github.com/kirbydesign/designsystem/tree/master) following our [branch naming convention](https://github.com/kirbydesign/designsystem/wiki/The-Good%3A-Branch).
46
+
-[ ] Create a branch from the [stable branch](https://github.com/kirbydesign/designsystem/tree/stable) following our [branch naming convention](https://github.com/kirbydesign/designsystem/wiki/The-Good%3A-Branch).
47
47
-[ ] Publish a WIP implementation to Github as a draft PR and ask for feedback.
48
48
-[ ] Make sure you have implemented tests following the guidelines in: "[The good: Test](https://github.com/kirbydesign/designsystem/wiki/The-Good%3A-Test)".
49
49
-[ ] Update the [cookbook](https://cookbook.kirby.design) with examples and showcases.
Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_TEMPLATE.md
+3-3Lines changed: 3 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -19,7 +19,7 @@ This PR closes # (insert issue number here)
19
19
20
20
## Checklist:
21
21
22
-
The following tasks should be carried out in sequence in order to follow [the process of contributing](https://github.com/kirbydesign/designsystem/blob/master/.github/CONTRIBUTING.md/#the-process-of-contributing) correctly.
22
+
The following tasks should be carried out in sequence in order to follow [the process of contributing](https://github.com/kirbydesign/designsystem/blob/stable/.github/CONTRIBUTING.md/#the-process-of-contributing) correctly.
23
23
24
24
### Reminders
25
25
-[ ] Make sure you have implemented tests following the guidelines in: "[The good: Test](https://github.com/kirbydesign/designsystem/wiki/The-Good%3A-Test)".
@@ -28,8 +28,8 @@ The following tasks should be carried out in sequence in order to follow [the pr
28
28
### Review
29
29
-[ ] Do a [self-review](https://github.com/kirbydesign/designsystem/wiki/The-Good%3A-Self-review).
30
30
-[ ] Request that the changes are code-reviewed
31
-
-[ ] Request that the changes are [UX reviewed](https://github.com/kirbydesign/designsystem/blob/master/.github/CONTRIBUTING.md/#ux-review) (only necessary if your PR introduces visual changes)
31
+
-[ ] Request that the changes are [UX reviewed](https://github.com/kirbydesign/designsystem/blob/stable/.github/CONTRIBUTING.md/#ux-review) (only necessary if your PR introduces visual changes)
32
32
33
-
When the pull request has been approved it will be automatically merged to master via [automerge](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/automatically-merging-a-pull-request).
33
+
When the pull request has been approved it will be automatically merged to `stable` via [automerge](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/automatically-merging-a-pull-request).
mediaType: '{"previews": ["flash", "ant-man"]}'# some parameters need preview: https://docs.github.com/en/rest/reference/repos#list-deployment-statuses-preview-notices
0 commit comments