Skip to content

AlAudioRenderer: update OpenAL state when dry filter is re-applied #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2022
Merged

AlAudioRenderer: update OpenAL state when dry filter is re-applied #1728

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc2c606
ALAudioRenderer: update direct-filter ID even when filter is up-to-date
stephengold Jan 3, 2022
6042050
ALAudioRenderer: update the copyright dates
stephengold Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions jme3-core/src/main/java/com/jme3/audio/openal/ALAudioRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2009-2021 jMonkeyEngine
* Copyright (c) 2009-2022 jMonkeyEngine
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
Expand Down Expand Up @@ -503,18 +503,18 @@ public void updateSourceParam(AudioSource src, AudioParam param) {
if (!supportEfx) {
return;
}

if (src.getDryFilter() != null) {
Filter f = src.getDryFilter();
if (f.isUpdateNeeded()) {
updateFilter(f);

// NOTE: must re-attach filter for changes to apply.
al.alSourcei(id, EFX.AL_DIRECT_FILTER, f.getId());
}
Filter dryFilter = src.getDryFilter();
int filterId;
if (dryFilter == null) {
filterId = EFX.AL_FILTER_NULL;
} else {
al.alSourcei(id, EFX.AL_DIRECT_FILTER, EFX.AL_FILTER_NULL);
if (dryFilter.isUpdateNeeded()) {
updateFilter(dryFilter);
}
filterId = dryFilter.getId();
}
// NOTE: must re-attach filter for changes to apply.
al.alSourcei(id, EFX.AL_DIRECT_FILTER, filterId);
break;
case Looping:
if (src.isLooping() && !(src.getAudioData() instanceof AudioStream)) {
Expand Down