AlAudioRenderer: update OpenAL state when dry filter is re-applied #1728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephengold
added
the
bug
stephengold
changed the title
|
Unless there's substantial discussion, I intend to self-integrate this PR in about 24 hours. |
stephengold
changed the title
stephengold
added a commit
that referenced
this pull request
Jan 10, 2022
…1728) * ALAudioRenderer: update direct-filter ID even when filter is up-to-date * ALAudioRenderer: update the copyright dates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to solve issue #1699 by updating OpenAL's direct-filter parameter whenever the
DryFilterchanges, even if the filter itself has already been initialized.I rearranged the
DryFilterlogic to make it slightly more readable.