Skip to content

[tests] device placement for non-denoiser components in group offloading LoRA tests #12103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2025
Merged

[tests] device placement for non-denoiser components in group offloading LoRA tests #12103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9ca31b
up
sayakpaul Aug 8, 2025
de057d0
Merge branch 'main' into group-offloading-lora-tests
sayakpaul Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/lora/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2400,7 +2400,6 @@ def _test_group_offloading_inference_denoiser(self, offload_type, use_stream):

components, _, _ = self.get_dummy_components(self.scheduler_classes[0])
pipe = self.pipeline_class(**components)
pipe = pipe.to(torch_device)
pipe.set_progress_bar_config(disable=None)
denoiser = pipe.transformer if self.unet_kwargs is None else pipe.unet

Expand All @@ -2416,6 +2415,10 @@ def _test_group_offloading_inference_denoiser(self, offload_type, use_stream):
num_blocks_per_group=1,
use_stream=use_stream,
)
# Place other model-level components on `torch_device`.
for _, component in pipe.components.items():
if isinstance(component, torch.nn.Module):
component.to(torch_device)
group_offload_hook_1 = _get_top_level_group_offload_hook(denoiser)
self.assertTrue(group_offload_hook_1 is not None)
output_1 = pipe(**inputs, generator=torch.manual_seed(0))[0]
Expand Down