Skip to content

[tests] device placement for non-denoiser components in group offloading LoRA tests #12103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2025
Merged

[tests] device placement for non-denoiser components in group offloading LoRA tests #12103

merged 2 commits into from
Aug 8, 2025

Conversation

@sayakpaul
Copy link
Member

@sayakpaul sayakpaul commented Aug 8, 2025

No description provided.

@sayakpaul sayakpaul requested a review from a-r-r-o-w August 8, 2025 03:58
a-r-r-o-w
a-r-r-o-w approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I believe this warning will be raised in the tests but should be okay

@sayakpaul sayakpaul merged commit 7b10e4a into main Aug 8, 2025
11 checks passed
@sayakpaul sayakpaul deleted the group-offloading-lora-tests branch August 8, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@a-r-r-o-w a-r-r-o-w a-r-r-o-w approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sayakpaul @a-r-r-o-w