Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
c309979
FFM-12192 Remove ConcurrentMap and sync metrics maps using mutexes
erdirowlands Nov 18, 2024
09c68b8
FFM-12192 Serialize MetricsEvent properly without logger
erdirowlands Nov 18, 2024
918be5e
FFM-12192 Freeze clones
erdirowlands Nov 18, 2024
3e938a4
FFM-12192 Use begin block for sending data errors
erdirowlands Nov 18, 2024
f15c89d
FFM-12192 Require set
erdirowlands Nov 18, 2024
5b17257
FFM-12192 Test for concurrent acecss to send_data_and_reset_cache
erdirowlands Nov 18, 2024
b24c38a
FFM-12192 Test for no evaluations
erdirowlands Nov 18, 2024
72b77a7
FFM-12192 Test for register_evaluations multiple threads
erdirowlands Nov 18, 2024
527a94c
FFM-12192 Test for metrics failing
erdirowlands Nov 18, 2024
4d20043
FFM-12192 Bump to 1.4.4
erdirowlands Nov 18, 2024
0996513
FFM-12192 MetricsEvent logger nil check
erdirowlands Nov 18, 2024
1a5c348
FFM-12192 Fix test
erdirowlands Nov 18, 2024
f9e43a9
FFM-12192 Place limit on seen targets
erdirowlands Nov 18, 2024
b0c2382
FFM-12192 Tidyup
erdirowlands Nov 18, 2024
37de12e
FFM-12192 Decrease stream processor thread pool from 100 to 20
erdirowlands Nov 18, 2024
1c61f60
FFM-12192 Fix comment
erdirowlands Nov 18, 2024
377a7ca
FFM-12192 Bump murmurhash
erdirowlands Nov 18, 2024
ed92961
FFM-12192 Replace metrics sleep with mutex condition
erdirowlands Nov 18, 2024
0caa230
FFM-12192 Use condition for timeout
erdirowlands Nov 18, 2024
6b9d14c
FFM-12192 Return default if we're still initiailzing
erdirowlands Nov 18, 2024
88fa7f8
FFM-12192 Don't wait for auth failures
erdirowlands Nov 18, 2024
301254a
FFM-12192 Hardening of evaluator error states
erdirowlands Nov 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
FFM-12192 MetricsEvent logger nil check
  • Loading branch information
erdirowlands committed Nov 18, 2024
commit 0996513aee8b1455b9ee4f7f9c9850a083c48e2b
8 changes: 6 additions & 2 deletions lib/ff/ruby/server/sdk/api/metrics_event.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ def eql?(other)
# project sizes. Issue being tracked in FFM-12192, and once resolved, can feasibly remove
# these checks in a future release.
unless other.is_a?(MetricsEvent)
@logger.warn("Warning: Attempted to compare MetricsEvent with #{other.class.name}" )
# We should always have a logger available except when we've deep cloned this class. We don't do any
# equality check on clones in metrics code anyway, so this is just a safety check.
if @logger
@logger.warn("Warning: Attempted to compare MetricsEvent with #{other.class.name}")
end
return false
end

Expand All @@ -42,7 +46,7 @@ def marshal_dump

def marshal_load(array)
@feature_config, @target, @variation = array
@logger = nil
@logger = nil
end


Expand Down