-
Notifications
You must be signed in to change notification settings - Fork 6
FFM-12192 Patch Four: Replace ConcurrentMap #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
554d36b
to
4d20043
Compare
erdirowlands
commented
Nov 18, 2024
@feature_name_attribute = "featureName" | ||
@variation_identifier_attribute = "variationIdentifier" | ||
|
||
@executor = Concurrent::FixedThreadPool.new(10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was not being used so safe to remove.
0ae4043
to
dbe7188
Compare
dbe7188
to
0996513
Compare
06b104d
to
f9e43a9
Compare
5864e63
to
b0c2382
Compare
akiraqb
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Concurrency Changes
concurrent-ruby/ConcurrentMap
with mutexes to resolve a segmentation fault that is seen under difficult to reproduce circumstances.Set
for seen targets to improve performance + places hard limit of 500k targets to stop unbounded growth.Condition
instead of a "dumb sleep" for wait_for_initialization and timeout usecasesTesting
Evaluator changes
Dependencies
murmurhash3
to 0.1.7Performance considerations