FFM-12192 Add guards for invalid Metrics #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdirowlands
force-pushed
the
FFM-12192-patch
branch
from
17c2c80 to
25aa6f9
Compare
akiraqb
approved these changes
Nov 12, 2024
…and add test for invalid metric / Fix tests
erdirowlands
force-pushed
the
FFM-12192-patch
branch
from
0c9b061 to
6ca9329
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We are seeing an edge case (see JIRA FFM-12192) where in very large project sizes the arguments passed to metrics functions can be invalid. We are still to root cause this, so this PR checks for invalid metrics data and skips them if detected.
Testing
New unit tests
Manual testing with valid and invalid inputs
Testgrid integration suite