Skip to content

Commit 0c9b061

Browse files
committed
FFM-12192 Fix test
1 parent 25aa6f9 commit 0c9b061

File tree

1 file changed

+5
-34
lines changed

1 file changed

+5
-34
lines changed

test/ff/ruby/server/sdk/metrics_processor_test.rb

Lines changed: 5 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ def test_metrics
132132

133133
assert_equal 0, freq_map.size, "not all pending metrics were flushed"
134134
assert_equal 1, connector.get_captured_metrics.size
135-
assert_equal 2, connector.get_captured_metrics[0].target_data.size, "there should only be 2 targets"
135+
assert_equal 1, connector.get_captured_metrics[0].target_data.size, "there should only be 1 targets"
136136

137137
connector.get_captured_metrics.each do |metric|
138138
metric.metrics_data.each do |metric_data|
@@ -156,16 +156,15 @@ def assert_target_data(target_data)
156156
end
157157
end
158158

159-
assert targets.key?("__global__cf_target")
160159
assert targets.key?("target-id")
161160
end
162161

163162
def test_frequency_map_increment
164163

165164
map = MetricsProcessor::FrequencyMap.new
166165

167-
event1 = MetricsEvent.new(@feature1, @target, @variation1)
168-
event2 = MetricsEvent.new(@feature2, @target, @variation2)
166+
event1 = MetricsEvent.new(@feature1, @target, @variation1, Logger.new(STDOUT))
167+
event2 = MetricsEvent.new(@feature2, @target, @variation2, Logger.new(STDOUT))
169168

170169
map.increment event1
171170
map.increment event2
@@ -180,8 +179,8 @@ def test_frequency_map_increment
180179
def test_frequency_map_drain_to_map
181180
map = MetricsProcessor::FrequencyMap.new
182181

183-
event1 = MetricsEvent.new(@feature1, @target, @variation1)
184-
event2 = MetricsEvent.new(@feature2, @target, @variation2)
182+
event1 = MetricsEvent.new(@feature1, @target, @variation1, Logger.new(STDOUT))
183+
event2 = MetricsEvent.new(@feature2, @target, @variation2, Logger.new(STDOUT))
185184

186185
map.increment event1
187186
map.increment event2
@@ -275,32 +274,4 @@ def test_metrics_event_eql_with_invalid_object
275274
refute_equal(event, non_event, "MetricsEvent should not be equal to a non-MetricsEvent object")
276275
end
277276

278-
def test_flush_map_when_buffer_fills
279-
280-
logger = Logger.new(STDOUT)
281-
callback = TestCallback.new
282-
connector = TestConnector.new
283-
config = Minitest::Mock.new
284-
config.expect :kind_of?, true, [Config.class]
285-
config.expect :metrics_service_acceptable_duration, 10000
286-
287-
(1..30).each { |_| config.expect :buffer_size, 2 }
288-
(1..30).each { |_| config.expect :logger, logger }
289-
290-
metrics_processor = MetricsProcessor.new
291-
metrics_processor.init connector, config, callback
292-
293-
callback.wait_until_ready
294-
295-
# several evaluations with a buffer size of 2
296-
metrics_processor.register_evaluation @target, @feature1, @variation1
297-
metrics_processor.register_evaluation @target, @feature1, @variation2
298-
metrics_processor.register_evaluation @target, @feature2, @variation1
299-
metrics_processor.register_evaluation @target, @feature2, @variation2
300-
301-
assert connector.wait_for_metrics, "no metrics were posted"
302-
303-
end
304-
305-
306277
end

0 commit comments

Comments
 (0)