Skip to content

Cmake module behavior #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Cmake module behavior #322

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08909b5
cmake: also handle an undefined CTRE C++ standard request
mathstuf Sep 16, 2024
3b0298f
cmake: claim knowledge of CMake 3.29
mathstuf Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.14.0)
cmake_minimum_required(VERSION 3.14...3.29)

if(CMAKE_VERSION VERSION_GREATER_EQUAL "3.29.20240416")
set(CMAKE_EXPERIMENTAL_CXX_IMPORT_STD "0e5b6991-d74f-4b3d-a41c-cf096e0b2508")
Expand Down Expand Up @@ -92,7 +92,7 @@ if(CTRE_MODULE)
)

# we are using `import std;`
if (CTRE_CXX_STANDARD LESS 23)
if (NOT DEFINED CTRE_CXX_STANDARD OR CTRE_CXX_STANDARD LESS 23)
set(CTRE_CXX_STANDARD 23)
endif()

Expand All @@ -113,6 +113,7 @@ else()
endif()

target_compile_features(${PROJECT_NAME} INTERFACE cxx_std_${CTRE_CXX_STANDARD})
set_property(TARGET ${PROJECT_NAME} PROPERTY CXX_SCAN_FOR_MODULES 0)

install(TARGETS ${PROJECT_NAME} EXPORT ${PROJECT_NAME}-targets)
endif()
Expand Down