Cmake module behavior #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is true because the code considers 3.29 in the next block. Of particular importance, this sets CMP0115 which scans C++20 sources by default. This allows tests to use `add_executable(t uses_module.cpp)` without having to explicitly say "I want to use `import ctre;`". In the non-module build, explicitly turn off scanning since it is not used.
mathstuf
force-pushed
the
cmake-module-behavior
branch
from
a9f8f81 to
3b0298f
Compare
|
why is there maximum version of 3.29? |
|
That is not a "maximum version". It is a "maximum tested version". It is saying "CMake 3.14 is required, but the project has been tested against all new policy behaviors up to 3.29 and accepts the new behaviors". |
hanickadot
approved these changes
Sep 16, 2024
|
Thanks! |
|
By setting the max version of cmake to 3.29 it changes the policy so that CXX_SCAN_FOR_MODULES is on by default which is important for modules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.